Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oracle SQL*Plus SET FEEDBACK support is incomplete #2559

Closed
alextercete opened this issue Nov 12, 2019 · 8 comments
Closed

Oracle SQL*Plus SET FEEDBACK support is incomplete #2559

alextercete opened this issue Nov 12, 2019 · 8 comments

Comments

@alextercete
Copy link

alextercete commented Nov 12, 2019

Which version and edition of Flyway are you using?

Flyway 6.0.8

Which client are you using? (Command-line, Java API, Maven plugin, Gradle plugin)

CLI

Which database are you using (type & version)?

Oracle 18.3

Which operating system are you using?

Windows

What did you do?

(Please include the content causing the issue, any relevant configuration settings, the SQL statement that failed (if relevant) and the command you ran.)

With oracle.sqlplus=true, ran the migration:

SET FEEDBACK ON
UPDATE practice SET modifieddate = sysdate;
What did you expect to see?

The output should contain 4 rows updated.

What did you see instead?

No feedback.

@martinmlouis
Copy link

martinmlouis commented Dec 4, 2019

Hi,
Eagerly waiting for this feature. Also I hope we will get output like
Procedure Created
Package Body Created and so on for PL/SQL DB Objects

@MikielAgutu
Copy link

MikielAgutu commented Feb 4, 2020

Note some usage of the SET FEEDBACK command is totally broken.


SET FEEDBACK 1;

Produces error:

ERROR: Unable to parse statement in sql\V1.1__first.sql at line 1 col 1: Unclosed counted closure near index 7 [0-9]{1-5}


SET FEEDBACK ONLY;

Produces error:

ERROR: Unable to parse statement in sql\V1__first.sql at line 62 col 1: SP2-0267: feedback option ONLY out of range (0 through 50000)

@MikielAgutu MikielAgutu changed the title SET FEEDBACK doesn't work with DELETE, INSERT or UPDATE Oracle SQL*Plus SET FEEDBACK support is incomplete Feb 4, 2020
@MikielAgutu
Copy link

MikielAgutu commented Mar 2, 2020

Somewhat fixed by #2659 but we still need to improve support.

@hermanjustin
Copy link

hermanjustin commented May 14, 2020

+1 - I was trying to get the SET FEEDBACK ON to work properly and finally searched for bugs and found that one was open. This would be much preferred to get the results of queries instead of running in debug -X mode with a filter.

@DoodleBobBuffPants
Copy link
Contributor

DoodleBobBuffPants commented Dec 17, 2020

@hermanjustin is SET FEEDBACK ON working properly for you now?

@hermanjustin
Copy link

hermanjustin commented Dec 17, 2020

Yes it was - released with 7.0 and works great!!!

@hermanjustin
Copy link

hermanjustin commented Dec 17, 2020

@hermanjustin is SET FEEDBACK ON working properly for you now?

Yes it was - released with 7.0 and works great!!!

@DoodleBobBuffPants
Copy link
Contributor

DoodleBobBuffPants commented Dec 17, 2020

Glad to hear it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants