Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package the oracle drivers #2642

Closed
Lyeeedar opened this issue Jan 27, 2020 · 6 comments
Closed

Package the oracle drivers #2642

Lyeeedar opened this issue Jan 27, 2020 · 6 comments
Assignees
Milestone

Comments

@Lyeeedar
Copy link
Contributor

@Lyeeedar Lyeeedar commented Jan 27, 2020

Package the oracle db drivers into flyway so they do not need to be downloaded and copied in manually by the user.

@MikielAgutu MikielAgutu added this to the Flyway 6.2.1 milestone Jan 27, 2020
@Lyeeedar
Copy link
Contributor Author

@Lyeeedar Lyeeedar commented Jan 27, 2020

@juliahayward juliahayward self-assigned this Jan 28, 2020
@MikielAgutu MikielAgutu removed this from the Flyway 6.2.1 milestone Jan 30, 2020
@MikielAgutu MikielAgutu added this to the Flyway 6.3 milestone Jan 30, 2020
@flyway flyway deleted a comment from juliahayward Jan 30, 2020
@MikielAgutu MikielAgutu reopened this Jan 30, 2020
@MikielAgutu
Copy link
Contributor

@MikielAgutu MikielAgutu commented Jan 30, 2020

Waiting for Oracle to confirm we can legally do this

@MikielAgutu
Copy link
Contributor

@MikielAgutu MikielAgutu commented Feb 5, 2020

Related to #2513

@juliahayward
Copy link
Member

@juliahayward juliahayward commented Feb 10, 2020

The concern about ending up with multiple drivers is not a problem - just tried, and if you have both odbc8-x.y.z.jar and odbc8-a.b.c.jar (or odbc10-a.b.c.jar for that matter) then the class loader is quite happy, it takes the first one it comes to. In the absence of us trying to be clever, that means taking the jars in alphabetical order.

@MikielAgutu MikielAgutu removed this from the Flyway 6.3 milestone Feb 10, 2020
@MikielAgutu MikielAgutu added this to the Flyway 6.2.3 milestone Feb 10, 2020
@juliahayward
Copy link
Member

@juliahayward juliahayward commented Feb 11, 2020

Done in 6.2.3

@davidkarlsen
Copy link

@davidkarlsen davidkarlsen commented Feb 11, 2020

Is this for the docker image, the maven plugin or the cli?

Lyeeedar added a commit that referenced this issue Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants