Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameters in JDBC URL #2678

Closed
juliahayward opened this issue Feb 18, 2020 · 4 comments
Closed

Parameters in JDBC URL #2678

juliahayward opened this issue Feb 18, 2020 · 4 comments

Comments

@juliahayward
Copy link
Member

juliahayward commented Feb 18, 2020

Arising from #2677 - it is possible to put user in the JDBC URL in which case the command line should not prompt for it. The fix for #2677 was Snowflake-specific, but it is worth a wider consideration that parameters may be passed in the JDBC URL (rather than the various config methods) and we can parse them out.

@MikielAgutu MikielAgutu added this to the Flyway 6.x milestone Feb 18, 2020
@MikielAgutu
Copy link

MikielAgutu commented Mar 2, 2020

@MikielAgutu MikielAgutu modified the milestones: Flyway 6.x, Flyway 6.4 Apr 7, 2020
@juliahayward
Copy link
Member Author

juliahayward commented Apr 8, 2020

This is going to be a case-by-case exercise as Oracle does it differently - see https://community.oracle.com/thread/221883

I'll have a look at genericising the code in the command line to make it easy to add new cases.

@MikielAgutu
Copy link

MikielAgutu commented Apr 9, 2020

We can do this for Azure auth too (MSI, Integrated, etc)

@juliahayward
Copy link
Member Author

juliahayward commented Apr 14, 2020

red-gate/flyway-main#230 moves the logic to the core, adds the Oracle credentials-in-URL case, and adds unit tests. It's too much of a case-by-case problem to have a truly generic solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants