Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print Flyway version in 'productVersion' property with -json #2682

Closed
MikielAgutu opened this issue Feb 19, 2020 · 1 comment
Closed

Print Flyway version in 'productVersion' property with -json #2682

MikielAgutu opened this issue Feb 19, 2020 · 1 comment

Comments

@MikielAgutu
Copy link
Contributor

@MikielAgutu MikielAgutu commented Feb 19, 2020

Currently if when running info -json you get something like:

{
  "productVersion": "1",
  "database": "flyway_db",
  "schemaVersion": "1",
  "schemaName": "",
  "migrations": [...]
}

The productVersion seems to always be the same as schemaVersion. I think it should actually be the version of Flyway (e.g. 6.2.3) instead.

Since it's a public API change it should be changed for V7.

@MikielAgutu MikielAgutu added this to the Flyway 7.x milestone Feb 19, 2020
@MikielAgutu MikielAgutu removed this from the Flyway 7.x milestone Feb 20, 2020
@MikielAgutu MikielAgutu added this to the Flyway 6.2.4 milestone Feb 20, 2020
@MikielAgutu
Copy link
Contributor Author

@MikielAgutu MikielAgutu commented Feb 20, 2020

This looks more like a bug than anything. Really this field isn't particularly useful. We're going to replace it with the Flyway version in a new property flywayVersion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant