Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix performance issue with the MySQLSchema doEmpty() call #2756

Closed
AlexisDeschamps opened this issue Apr 2, 2020 · 2 comments
Closed

Fix performance issue with the MySQLSchema doEmpty() call #2756

AlexisDeschamps opened this issue Apr 2, 2020 · 2 comments
Milestone

Comments

@AlexisDeschamps
Copy link
Contributor

AlexisDeschamps commented Apr 2, 2020

Hello, I am creating a new issue to report the problem described in #2123. As specified by @golbi's comment on the issue, the PR merged for the original issue did not really solve the problem of filtering by TRIGGER_SCHEMA instead of EVENT_OBJECT_SCHEMA. As explained in #2123, EVENT_OBJECT_SCHEMA will provide significantly better performance.

I have implemented the fix in #2750 (it's a one-line change). Please let me know if there's anything I could to do help merge the PR and for a new Flyway version to be released. Thanks!

Which version and edition of Flyway are you using?

Flyway 6.3.2

Which client are you using? (Command-line, Java API, Maven plugin, Gradle plugin)

Java API

Which database are you using (type & version)?

MySQL 5.7

Which operating system are you using?

Linux containers.

What did you do?

Execute flyway.migrate() with baselineOnMigrate = true on a database that had not been migrated by Flyway before.

What did you expect to see?

A relatively fast first migration/baseline (e.g. a few hundreds of milliseconds).

What did you see instead?

An extremely slow first migration/baseline (e.g. a few tens of minutes - we have a lot of logical databases).

@Lyeeedar
Copy link
Contributor

Lyeeedar commented Apr 7, 2020

Relates to #2750

@MikielAgutu MikielAgutu added this to the Flyway 6.4 milestone Apr 7, 2020
@AlexisDeschamps
Copy link
Contributor Author

AlexisDeschamps commented Apr 15, 2020

Closing this since the fix was merged in #2750.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants