You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.
We are encountering SQL parsing errors when single quotes are adjacent to characters not explicitly specified as token delimiters in SqlStatementBuilder.endsWithOpenMultilineStringLiteral.
I think your approach of splitting on SQL special characters may be the issue. I think there are many other special characters (see http://savage.net.au/SQL/sql-2003-2.bnf.html) and also multiple-character sequences ('--') which may need to be included.
Please see related issue #544, in which I suggest two options to reduce or eliminate these parsing errors.
Thanks,
Brian
The text was updated successfully, but these errors were encountered:
Axel,
We are encountering SQL parsing errors when single quotes are adjacent to characters not explicitly specified as token delimiters in SqlStatementBuilder.endsWithOpenMultilineStringLiteral.
To reproduce, add these assertions to a test:
assertFalse(new SQLServerSqlStatementBuilder().endsWithOpenMultilineStringLiteral("print 'baz'+"));
assertFalse(new SQLServerSqlStatementBuilder().endsWithOpenMultilineStringLiteral("print 'baz'-- Oops"));
I think your approach of splitting on SQL special characters may be the issue. I think there are many other special characters (see http://savage.net.au/SQL/sql-2003-2.bnf.html) and also multiple-character sequences ('--') which may need to be included.
Please see related issue #544, in which I suggest two options to reduce or eliminate these parsing errors.
Thanks,
Brian
The text was updated successfully, but these errors were encountered: