Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent definition of "locations" parameter #612

Closed
cowwoc opened this issue Sep 22, 2013 · 1 comment
Closed

Inconsistent definition of "locations" parameter #612

cowwoc opened this issue Sep 22, 2013 · 1 comment
Milestone

Comments

@cowwoc
Copy link

@cowwoc cowwoc commented Sep 22, 2013

Flyway field "locations" has a default value of "db/migration" and the Javadoc says nothing about "classpath:" or "filesystem:" prefixes. On the other hand, the documentation says that these two prefixes must be used.

  1. Why was "filesystem:" and "classpath:" introduced? Couldn't we always treat entries in this field as appearing on the classpath and add filesystem entries to the classpath that Flyway is launched with?
  2. The online documentation, field default value and Javadoc should be consistent with each other.

Personally I prefer removing the prefixes and telling users to add filesystem entries to the classpath when launching Flyway (you can do the same in the Maven plugin).

@cowwoc
Copy link
Author

@cowwoc cowwoc commented Sep 22, 2013

Digging into the code I discovered that the lack of a prefix gets interpreted as a classpath entry. So the default value should be okay.

I tried scanning through the commit logs but couldn't figure out why the "filesystem:" prefix was added in the first place...

@axelfontaine axelfontaine added this to the Flyway 3.0 milestone Feb 23, 2014
@axelfontaine axelfontaine removed this from the Flyway 2.3 milestone Feb 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants