Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flyway does handle multi-line comment directives of the form:
/*!50001 CREATE ALGORITHM=UNDEFINED */ /*!50013 DEFINER=`user`@`%` SQL SECURITY DEFINER */ /*!50001 VIEW `viewname` AS select `t`.`id` AS `someId`,`t`.`name` AS `someName` from `someTable` `t` where `t`.`state` = 0 */;
However, the following is a valid extract from a mysql dump:
-- MySQL dump 10.13 Distrib 5.5.16, for Win32 (x86) -- -- Host: 127.0.0.1 Database: badgers -- ------------------------------------------------------ -- Server version 5.1.61 /*!50001 CREATE TABLE `badger` ( `id` int(11) unsigned, `badger_type` int(11) unsigned ) ENGINE=MyISAM */;
It is not recognised as being a comment directive, as the code in SqlScript.java assumes that a comment directive will be contained on one line:
SqlScript.java
if (!sqlStatementBuilder.isCommentDirective(trimmedLine)) {
This is somewhat related to #558.
The text was updated successfully, but these errors were encountered:
flyway#640 - Comment directives can span multiple lines.
cc5586b
Merged.
Successfully merging a pull request may close this issue.
Flyway does handle multi-line comment directives of the form:
However, the following is a valid extract from a mysql dump:
It is not recognised as being a comment directive, as the code in
SqlScript.java
assumes that a comment directive will be contained on one line:This is somewhat related to #558.
The text was updated successfully, but these errors were encountered: