Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean doesn't handle temporal/versioned tables correctly in DB2. #663

Closed
boothen opened this issue Dec 13, 2013 · 3 comments
Closed

Clean doesn't handle temporal/versioned tables correctly in DB2. #663

boothen opened this issue Dec 13, 2013 · 3 comments

Comments

@boothen
Copy link
Contributor

@boothen boothen commented Dec 13, 2013

Flyway clean fails when it's trying to delete a temporal table.

The temporal table is automatically deleted when the table it relates to is deleted. The delete of the temporal table then fails as the table is no longer present.

We've worked around this by extending various classes so that we can use an extended implementation of DB2Schema. This class identifies any temporal tables and drops versioning. Allowing the tables to be deleted as normal.

It would be useful to have the ability to easily use a custom implementation of the Schema class.

I believe this pull request would enable this.

#629

@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Dec 13, 2013

Would it be OK to contribute your changes back as a pull request so other users can benefit?

@boothen
Copy link
Contributor Author

@boothen boothen commented Dec 13, 2013

I've created a pull request. It's my first so apologies in advance if it's not done incorrectly.

#664

@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Dec 16, 2013

Merged.

Cheers
Axel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants