Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maven Plugin - Cannot set boolean system property (REGRESSION) #682

Closed
regis-leray opened this issue Jan 27, 2014 · 0 comments
Closed

Maven Plugin - Cannot set boolean system property (REGRESSION) #682

regis-leray opened this issue Jan 27, 2014 · 0 comments

Comments

@regis-leray
Copy link

@regis-leray regis-leray commented Jan 27, 2014

I discover a big issue in the maven plugin in flyway 2.3.1, you cannot set any boolean property with a java system property.

i did some debuging and the method getBooleanProperty got a very small bug.
Boolean.getBoolean(systemPropertyValue) should be Boolean.getBoolean(systemPropertyName)

/**
* Retrieves the value of this boolean property, based on the matching System on the Maven property.
*
* @param systemPropertyName The name of the System property.
* @param mavenPropertyValue The value of the Maven property.
* @return The value to use.
*/
boolean getBooleanProperty(String systemPropertyName, boolean mavenPropertyValue) {
String systemPropertyValue = System.getProperty(systemPropertyName);
if (systemPropertyValue != null) {
return Boolean.getBoolean(systemPropertyName);
}
return mavenPropertyValue;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.