Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derby ClientDriver support #909

Closed
vaesbart opened this issue Dec 14, 2014 · 2 comments
Closed

Derby ClientDriver support #909

vaesbart opened this issue Dec 14, 2014 · 2 comments

Comments

@vaesbart
Copy link

@vaesbart vaesbart commented Dec 14, 2014

I was trying to use Flyway in my JavaFX project the other day, which uses a Derby / JavaDB database.
To my surprise Flyway currently only supports the EmbeddedDriver, and not the ClientDriver.

Seeing that the Embedded driver is more limited (single app that accesses db) than the ClientDriver (client/server environment) I'd like to ask for ClientDriver support.

I found this code in the DriverDataSource.java class, which seems to be a good starting point ?

DriverDataSource.java
155 if (url.startsWith("jdbc:derby:")) {
156 return "org.apache.derby.jdbc.EmbeddedDriver";
157 }

@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Dec 15, 2014

If you use the API, you can pass in your own datasource.

For the other clients, you can specify the driver class to use with flyway.driver.

But the driver autodetection, based on the url, could indeed be improved. Then the client driver could also ship by default with the command-line tool.

@vaesbart
Copy link
Author

@vaesbart vaesbart commented Dec 15, 2014

Ok, I reviewed my code and managed to 'attach' my datasource to flyway, so it works :)
Thanks.

axelfontaine added a commit to flyway/flywaydb.org that referenced this issue Feb 25, 2015
jmahonin added a commit to jmahonin/flyway that referenced this issue Jul 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants