Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiline comment closing not detected properly #939

Closed
david-mas opened this issue Jan 23, 2015 · 1 comment
Closed

Multiline comment closing not detected properly #939

david-mas opened this issue Jan 23, 2015 · 1 comment

Comments

@david-mas
Copy link

@david-mas david-mas commented Jan 23, 2015

Flyway cannot tell the multi line comment closing apart when there is a single line comment attached to it. Using flyway-maven-plugin, version 3.1
Example below.

/**
--insert something
INSERT INTO mytable (id, data1, data2)VALUES (3,1,'hi');
**/-- Comment on the same line attached to the multiline closing
--these statements are not imported because end of multiline is not detected
INSERT INTO mytable (id, data1, data2)VALUES (1,1,'hi');
/**
--insert something
INSERT INTO mytable (id, data1, data2)VALUES (4,1,'hi');
**/
--these statements are imported the above multiline is detected
INSERT INTO mytable (id, data1, data2)VALUES (5,1,'hi');

Note this is valid sql syntax and therefore the script loads correctly on the dmbs.

@axelfontaine axelfontaine added this to the Flyway 3.2 milestone Jan 25, 2015
axelfontaine added a commit to flyway/flywaydb.org that referenced this issue Mar 4, 2015
@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Mar 4, 2015

Fixed. I actually took the opportunity to simplified the comment parsing code which I wasn't happy about for a long time.

Cheers
Axel

jmahonin pushed a commit to jmahonin/flyway that referenced this issue Jul 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants