Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail on invalid command-line options #977

Closed
eduardopiairo opened this issue Mar 26, 2015 · 2 comments
Closed

Fail on invalid command-line options #977

eduardopiairo opened this issue Mar 26, 2015 · 2 comments

Comments

@eduardopiairo
Copy link

@eduardopiairo eduardopiairo commented Mar 26, 2015

Hello,

I was applying a set of migrations using Flyway Command-line. I wanted to use the option -target to specify the target version because a had more scripts (to migrate in future). However, when i wrote the option i wrote it wrong: "flyway -targte=20150326 migrate" and all scripts were migrated (it wasn't wat i wanted).

Wrong options shouldn't permite execute commands. In situations like this an error could be printed to user in order to correct it. In other words, options should be validated.

Thanks,
Eduardo Piairo

@axelfontaine axelfontaine changed the title Command-line options Fail on invalid command-line options Mar 27, 2015
@axelfontaine axelfontaine added this to the Flyway 4.0 milestone Mar 27, 2015
@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Mar 27, 2015

Hi Eduardo,

yes, I fully agree fail-fast is preferable here.

Cheers
Axel

@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Dec 29, 2015

I turned this into a warning instead of an error due to potential compatibility issues with people using flyway.conf between multiple tools

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.