Redshift-specific JDBC driver support #1119
Merged
Conversation
added 3 commits
Oct 31, 2015
These two databases seem to be evolving differently.
|
Awesome work Nathan! Truly appreciated! |
added 2 commits
Nov 2, 2015
…Types.NULL (For JdbcTemplate.nullType) This makes it a little bit more complicated to support both the PostgreSQL driver and the new Redshift-specific driver (when using Redshift), but I think we still need to support the PostgreSQL driver for now.
…ar quoting Dollar quoting is an undocumented feature of Redshift, which it inherits from PostgreSQL. Multiline dollar quoting does not work with the new Redshift-specific JDBC driver. However, multiline dollar quoting still works when connecting to Redshift via the PostgreSQL driver. Tests for multiline dollar quoting have been removed, seeing as it does not work with the official JDBC driver.
|
I added some more fixes, to make the tests pass if using the Redshift JDBC driver. The Redshift tests now work with either the PostgreSQL driver or the Redshift driver. |
|
I think these last two commits should be integrated into flyway 4. |
axelfontaine
added a commit
that referenced
this pull request
Dec 23, 2015
Add support for the Redshift-specific JDBC driver
axelfontaine
changed the title
|
Thank you very much Nathan! Merged. |
axelfontaine
added a commit
to flyway/flywaydb.org
that referenced
this pull request
Dec 23, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Proposed implementation #1058, using detectDriverForUrl for the JDBC 4.1 driver and detectBackupDriverForUrl for JDBC 4 driver. I also had to fix a couple of bugs along the way to make the tests pass.