Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redshift-specific JDBC driver support #1119

Merged
merged 5 commits into from Dec 23, 2015
Merged

Conversation

@nathanvick
Copy link
Contributor

@nathanvick nathanvick commented Oct 31, 2015

Proposed implementation #1058, using detectDriverForUrl for the JDBC 4.1 driver and detectBackupDriverForUrl for JDBC 4 driver. I also had to fix a couple of bugs along the way to make the tests pass.

Nathan Vick added 3 commits Oct 31, 2015
After f31e1a5, the schema was set to " public".

Also, 1dae524 exposed a bug in clean. It was
relying on "drop table ... cascade" to drop views, but this approach failed to
drop views that are based on system tables.
These two databases seem to be evolving differently.
@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Nov 1, 2015

Awesome work Nathan! Truly appreciated!

Nathan Vick added 2 commits Nov 2, 2015
…Types.NULL

(For JdbcTemplate.nullType)

This makes it a little bit more complicated to support both the PostgreSQL driver
and the new Redshift-specific driver (when using Redshift), but I think we still
need to support the PostgreSQL driver for now.
…ar quoting

Dollar quoting is an undocumented feature of Redshift, which it inherits from PostgreSQL.
Multiline dollar quoting does not work with the new Redshift-specific JDBC driver. However,
multiline dollar quoting still works when connecting to Redshift via the PostgreSQL driver.

Tests for multiline dollar quoting have been removed, seeing as it does not work with
the official JDBC driver.
@nathanvick
Copy link
Contributor Author

@nathanvick nathanvick commented Nov 2, 2015

@axelfontaine,

I added some more fixes, to make the tests pass if using the Redshift JDBC driver. The Redshift tests now work with either the PostgreSQL driver or the Redshift driver.

@nathanvick
Copy link
Contributor Author

@nathanvick nathanvick commented Nov 17, 2015

@axelfontaine,

I think these last two commits should be integrated into flyway 4.

axelfontaine added a commit that referenced this pull request Dec 23, 2015
Add support for the Redshift-specific JDBC driver
@axelfontaine axelfontaine merged commit b82c740 into flyway:master Dec 23, 2015
@axelfontaine axelfontaine changed the title Add support for the Redshift-specific JDBC driver Redshift-specific JDBC driver support Dec 23, 2015
@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Dec 23, 2015

Thank you very much Nathan! Merged.

axelfontaine added a commit to flyway/flywaydb.org that referenced this pull request Dec 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.