Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modification of OsgiClassPathLocationScanner to support not only current bundle #1143

Merged
merged 1 commit into from Jan 20, 2016

Conversation

@dzharikhin
Copy link

@dzharikhin dzharikhin commented Dec 9, 2015

enhancement for #1142.
Makes OsgiClassPathLocationScanner try to get target bundle from url first instead of the current one if possible. If it's not possible it still keeps fallback to current bundle

try to get target bundle from url instead of the current one if possible
@dzharikhin dzharikhin changed the title enhancement for #1142 Modification of OsgiClassPathLocationScanner to support not only current bundle Dec 10, 2015
@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Dec 23, 2015

I saw you closed the original issue. Is this PR still relevant? For what environment/constellation exactly is current situation a problem that would be resolved by this?

@dzharikhin
Copy link
Author

@dzharikhin dzharikhin commented Dec 25, 2015

Hi! Yes it is. I closed the ticket just because all the info related is here.
This PR allows you to search migration files in another bundle.
My example is: I build on demand migration service based on OSGi, which is the one who knows about DB. So, other OSGi bundles just consume this service on install phase to support their own "sub-schemas"

@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Dec 29, 2015

I am still not sure I fully get it. Which OSGi runtimes are affected by this? Why aren't fragments sufficient to solve this?

@dzharikhin
Copy link
Author

@dzharikhin dzharikhin commented Dec 29, 2015

Well, now I'm trying to integrate Flyway into Atlassian products, their plugin infrastructure.
Instead of ActiveObjects I suggest to use Flyway+MyBatis.
In Jira plugin is a bundle, but there's no way to create a fragment-bundle there. But I need to use resources from these plugins to execute migrations related to specific plugins.
That's why I need this so much

axelfontaine added a commit that referenced this pull request Jan 20, 2016
Modification of OsgiClassPathLocationScanner to support not only current bundle
@axelfontaine axelfontaine merged commit 362c5e5 into flyway:master Jan 20, 2016
@axelfontaine axelfontaine added this to the Flyway 4.0 milestone Jan 20, 2016
@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Jan 20, 2016

Thanks! Merged.

@dzharikhin dzharikhin deleted the dzharikhin:1142-osgi-scanner-enhancement branch Apr 6, 2016
@dzharikhin dzharikhin restored the dzharikhin:1142-osgi-scanner-enhancement branch Apr 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.