Fix for Sybase ASE 15.7 identification string #1221
Conversation
Fetch flyway 4.0 release
| @@ -131,7 +131,7 @@ public static DbSupport createDbSupport(Connection connection, boolean printInfo | |||
| } | |||
|
|
|||
| //Sybase ASE support | |||
| if (databaseProductName.startsWith("ASE")) { | |||
| if (databaseProductName.startsWith("Adaptive Server Enterprise")) { | |||
There was a problem hiding this comment.
This should really accept both otherwise you'll break the latest version
There was a problem hiding this comment.
Is there actually a SAP ASE database that returns "ASE" or is it the same as Sybase ASE that returns "Adaptive Server Enterprise"?
There was a problem hiding this comment.
From what I tested in ASE 15.2, it returns ASE. I think the name is different in 15.7?
There was a problem hiding this comment.
OK, then let's make sure we allow both for Flyway 4.0.1
There was a problem hiding this comment.
@hakkika Can you update this PR to allow both the old and the new name?
There was a problem hiding this comment.
My fix should now allow both names. Can you see the change in the pull
request?
On Tue, Mar 1, 2016 at 4:38 PM, Axel Fontaine notifications@github.com
wrote:
In
flyway-core/src/main/java/org/flywaydb/core/internal/dbsupport/DbSupportFactory.java
#1221 (comment):@@ -131,7 +131,7 @@ public static DbSupport createDbSupport(Connection connection, boolean printInfo
}//Sybase ASE support
if (databaseProductName.startsWith("ASE")) {if (databaseProductName.startsWith("Adaptive Server Enterprise")) {@hakkika https://github.com/hakkika Can you update this PR to allow
both the old and the new name?—
Reply to this email directly or view it on GitHub
https://github.com/flyway/flyway/pull/1221/files#r54574564.
t. Kari Häkkinen
|
Have you run the Sybase tests to see if they all pass with your version? |
|
I have not run any Sybase tests because I am not able to build flyway unless skipping all tests. |
|
Do they pass in your IDE? |
|
I am sorry, but I am not a Java developer and running the tests in IDE is not something I know how to do either. I just am interested in Sybase ASE support in flyway. |
Fix for Sybase ASE 15.7 identification string
|
Thanks! Merged. |
No description provided.