-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for EnterpriseDB flavor of PostgreSQL #1286
Conversation
* New dialect supporting the weird blend of Oracle and PostgreSQL known as SPL. * Unit tests Unit tests pass 76 tests pass, 3 ignored. While both the DB and the JDBC drivers support these operations, I just didn't have time to make the underlying functionality work as expected. Therefore the following functionality is not supported or tested: * xml types and indexes * text types and indexes * pg_copy There are some known bugs with the EDB JDBC drivers, which prevent certain functionality, or cause otherwise functional migrations to die unexpectedly: * TYPE BODY cannot be executed. * Package Body with complex comments causes ArrayOutOfBoundsException.
set PGPASSWORD=flyway | ||
psql -Upostgres < flyway-core/src/test/resources/migration/dbsupport/postgresql/createDatabase.sql | ||
edb-psql -Uenterprisedb < flyway-core/src/test/resources/migration/dbsupport/postgresql/createDatabase.sql | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to be some kind of mixup here as we now have two EnterpriseDB sections...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Darnit! Sorry about that...
@axelfontaine - was there anything else you needed from me on this PR? |
* TYPE BODY is now supported. * Complex Comments test now passes. Fixed a bug in the package test script - default is for EDB (and PostgreSQL) is to have check_function_body = true, which enforces schema checks during package creation. The package test script needed to include table creation in order for the package to compile.
Thanks for the pull request. Merged. I unfortunately still had to do a bunch of cleaning up :-/ Would you be willing to support this in the future? |
With the non-transactional support for PostgreSQL part of 4.1 it may be worth submitting a pull request to bring this in line for the next release. What do you think? |
@axelfontaine I am very sorry to have missed your request for help during the merge! In the future I will absolutely be available to help, as I did commit to supporting this going forward. Once again, sorry for the late reply, and the extra-difficult merge. 👎 |
EnterpriseDB Postgres Plus Advanced Server
as SPL.
Unit tests pass
76 tests pass, 3 ignored. While both the DB and the JDBC drivers support
these operations, I just didn't have time to make the underlying functionality
work as expected. Therefore the following functionality is not supported
or tested:
There are some known bugs with the EDB JDBC drivers, which prevent
certain functionality, or cause otherwise functional migrations to die
unexpectedly: