Make baseline() idempotent even after applying migrations #1345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baselining a second time after applying migrations threw an Exception even though the baseline version and description didn't change. This commit allows executing the baseline command again after applying migrations as long as the baseline version and description do not change.
axelfontaine
changed the title
axelfontaine
pushed a commit
to flyway/flywaydb.org
that referenced
this pull request
Jan 31, 2017
|
Thanks for the pull request. I personally don't see the exact need for this. However I am all for making things idempotent and the change is rather small, so approved. |
|
@axelfontaine For us it will be useful in test environments where we use Flyway to test db migrations on schemas with (almost) productive data. The test does basically set a baseline and applies new scripts. If the baseline was already set (because the test has already been executed once on that schema), the build crashed. With this fix we can remove the hacks we had to make to work around this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Baselining a second time after applying migrations threw an Exception even though the baseline version and description is the same. This PR allows executing the baseline command again after applying migrations as long as the baseline version and description do not change. In such a case the baseline command won't do anything.
This feature is especially useful in automated test environments where baselining or migrations might have taken place or not.
Before changing the
DbBaslineclass, I wrote some unit tests to make sure that I don't accidentally break something. After changing the class I added some more tests for this new feature.