#1531: Fix for CREATE PROCEDURE in SAP HANA dialect #1532
This is a preliminary fix for #1531.
Some things might be reconsidered:
Please let me know if the fix is going in the right direction, then I can work a little more on these items.
The text was updated successfully, but these errors were encountered:
…dures with embedded semicola. Now recognizes that the statement ends only after the semicolon behind the terminating END;
Feat/support procedures with semicola Patched Hana SqlStatementBuilder along with a test case See merge request !1
I resolved all your comments and added a couple of tests for these scenarios. In addition, I'll leave some replies to your comments explaining what I did.
I can still think of a thousand ways to break this functionality:
In order to solve all these issues properly, we would have to have some kind of parser that's fully aware of the syntax (we're already implementing a part of it in this functionality). But this would be a major change in the base class, and would be misplaced to implement just in this subclass.
So I think we have covered fairly common cases which is better than nothing.