Fix Tomcat URL handling fallout #1555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelfontaine
suggested changes
Mar 14, 2017
| JarFileClassPathLocationScanner locationScanner = new JarFileClassPathLocationScanner(); | ||
| JarFileClassPathLocationScanner locationScanner; | ||
| if ("war".equals(protocol)) { | ||
| locationScanner = new JarFileClassPathLocationScanner("*/"); |
There was a problem hiding this comment.
Won't this be breaking older Tomcat releases?
There was a problem hiding this comment.
I don't think so, as older tomcat version will return URLs like jar:xxx!/ for war files, and new tomcats will return URLs like war:xxx*/. but somebody should test this...
There was a problem hiding this comment.
Hi, I manually did test this patch against Tomcat 8.5.5 and 8.5.13 (old and new URL handling) with plain 4.1.2 and patched 4.1.2.
The patched 4.1.2 always works correctly in all four constellations.
Do you need anything else to merge this PR?
There was a problem hiding this comment.
OK, works for me. Thanks for verifying!
axelfontaine
approved these changes
Apr 3, 2017
|
@thomasmey Could you please get in touch with me by email? (axel at boxfuse.com) Thanks! |
dohrayme
pushed a commit
to dohrayme/flyway
that referenced
this pull request
Feb 3, 2020
Fix Tomcat URL handling fallout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1549
Untested proposed fix.
Patch against 4.1.2