Fix Tomcat URL handling fallout #1555
Merged
Conversation
| JarFileClassPathLocationScanner locationScanner = new JarFileClassPathLocationScanner(); | ||
| JarFileClassPathLocationScanner locationScanner; | ||
| if ("war".equals(protocol)) { | ||
| locationScanner = new JarFileClassPathLocationScanner("*/"); |
axelfontaine
Mar 14, 2017
Contributor
Won't this be breaking older Tomcat releases?
Won't this be breaking older Tomcat releases?
thomasmey
Mar 14, 2017
Author
Contributor
I don't think so, as older tomcat version will return URLs like jar:xxx!/ for war files, and new tomcats will return URLs like war:xxx*/. but somebody should test this...
I don't think so, as older tomcat version will return URLs like jar:xxx!/ for war files, and new tomcats will return URLs like war:xxx*/. but somebody should test this...
thomasmey
Mar 31, 2017
Author
Contributor
Hi, I manually did test this patch against Tomcat 8.5.5 and 8.5.13 (old and new URL handling) with plain 4.1.2 and patched 4.1.2.
The patched 4.1.2 always works correctly in all four constellations.
Do you need anything else to merge this PR?
Hi, I manually did test this patch against Tomcat 8.5.5 and 8.5.13 (old and new URL handling) with plain 4.1.2 and patched 4.1.2.
The patched 4.1.2 always works correctly in all four constellations.
Do you need anything else to merge this PR?
axelfontaine
Apr 3, 2017
Contributor
OK, works for me. Thanks for verifying!
OK, works for me. Thanks for verifying!
|
@thomasmey Could you please get in touch with me by email? (axel at boxfuse.com) Thanks! |
dohrayme
pushed a commit
to dohrayme/flyway
that referenced
this pull request
Feb 3, 2020
Fix Tomcat URL handling fallout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Issue #1549
Untested proposed fix.
Patch against 4.1.2