Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make default resolvers handle all locations in one instance #1566

Merged
merged 1 commit into from Mar 30, 2017

Conversation

@pauxus
Copy link
Contributor

@pauxus pauxus commented Mar 22, 2017

... instead of the previous 'one resolver per single location'. This makes the default resolvers behave more like custom resolvers and is a step on the way to eventually allow subclasses of default resolvers as custom resolvers.

This PR has no direct effect in itself, but provides only the base.

This is basically a revisit of #1183 and #1185

@axelfontaine : Since there will be more than one commit to this topic, I would rather put them all into one PR but as separate commits. Or do you rather want single PRs for all steps?

... instead of the previous 'one resolver per single location'. This makes the default resolvers behave more like custom resolvers
and is a step on the way to eventually allow subclasses of default resolvers as custom resolvers.
@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Mar 22, 2017

Single PRs are easier to digest/accept/reject. I highly encourage you to write down your plan for each PR in an issue first to avoid unnecessary work if it has no chance of being accepted.

@axelfontaine axelfontaine merged commit 4ca6874 into flyway:master Mar 30, 2017
@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Mar 30, 2017

Good idea! Aligning internal resolvers with custom ones makes sense!

Thanks for the pull request!

axelfontaine added a commit to flyway/flywaydb.org that referenced this pull request Mar 30, 2017
dohrayme pushed a commit to dohrayme/flyway that referenced this pull request Feb 3, 2020
…isited

Make default resolvers handle all locations in one instance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants