Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert classpath with cygpath if it is available regardless of uname output #1643

Merged
merged 2 commits into from Nov 26, 2017

Conversation

@tiborbaksa
Copy link
Contributor

@tiborbaksa tiborbaksa commented May 18, 2017

This is a possible fix for #1642.

Cygwin detection fails on Git for Windows because uname returns MSYS_NT-10.0 which does not match the known patterns. Instead of expanding the patterns, a more generic solution is to use cygpath if there is such a command.

I was not able to find any case in Google when cygpath was installed on a non-Windows system, therefore I think it is safe to assume that if cygpath is available, the classpath needs to be converted to a Windows path list. A better solution would be to let cygpath detect the system, but unfortunately this is not supported.

This pull request also replaces the $(...) syntax with backticks when calling cygpath to make the script more consistent. If this change poses an issue, please let me know and I will revert it.

@axelfontaine axelfontaine added this to the Flyway 5.0.0 milestone May 19, 2017
@axelfontaine axelfontaine merged commit 1059efa into flyway:master Nov 26, 2017
1 check passed
dohrayme pushed a commit to dohrayme/flyway that referenced this issue Feb 3, 2020
Convert classpath with cygpath if it is available regardless of uname output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants