Fixes #1654: Switch to a spin pg_try_advisory_lock #1656
Closed
Conversation
|
Could you sign the CLA and resolve conflicts so this can be merged? Thanks! |
|
Apologies. I didn't see your previous comment. I have signed the CLA now and resolved the merge conflicts |
Postgres can deadlock with a pending pg_advisory_lock and a long running CREATE INDEX CONCURRENTLY statement. * Reproduce the deadlock in PostgreSQLConcurrentMigrationMediumTest with a modified version of the regular ConcurrentMigrationMediumTest * Modify PostgreSQLAdvisoryLockTemplate to spin until pg_try_advisory_lock returns true or it is interrupted * Sleep for 100ms on failed attempt to acquire the advisory lock
|
The build appears to be failing even after rebasing onto the commit for the latest green build. It seems like the same tests are failing on master. |
|
Thanks for contributing this. Your code has been integrated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Postgres can deadlock with a pending pg_advisory_lock and
a long running CREATE INDEX CONCURRENTLY statement.
with a modified version of the regular ConcurrentMigrationMediumTest
pg_try_advisory_lock returns true or it is interrupted