Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support TestContainers JDBC connection string #1663

Merged

Conversation

@inikolaev
Copy link
Contributor

@inikolaev inikolaev commented Jun 7, 2017

I would like to propose this change in order to support TestContainers JDBC connection string.

This way it will be possible to run database migration scripts against Dockerized database instance started by TestContainers.

Let me know if you have any questions.

@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Jun 8, 2017

We are certainly interested in moving in this direction. I assume this PR is only the initial step and that a few more will follow. Could you detail your overall vision of what the final solution, when completed, would look like and which intermediate steps you see would be needed to get there?

@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Jun 8, 2017

Related to #1579

@inikolaev
Copy link
Contributor Author

@inikolaev inikolaev commented Jun 8, 2017

With this change I merely wanted to add support for TestContainers. It's not about Flyway tests to use it internally at the moment.

I have a use case of being able to run database migration script against TestContainers database and using that database during development without using Docker Compose. This change along with testcontainers/testcontainers-java#360 will allow to achieve this goal.

@inikolaev
Copy link
Contributor Author

@inikolaev inikolaev commented Jun 11, 2017

@axelfontaine Is there anything I can do to facilitate with for this to be merged?

@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Sep 19, 2017

@inikolaev Can you sign the CLA so this can be merged?

@inikolaev
Copy link
Contributor Author

@inikolaev inikolaev commented Sep 19, 2017

@axelfontaine axelfontaine added this to the Flyway 5.0.0 milestone Sep 19, 2017
@axelfontaine axelfontaine merged commit 0d66a12 into flyway:master Nov 27, 2017
1 check passed
1 check passed
license/cla Contributor License Agreement is signed.
Details
axelfontaine added a commit to flyway/flywaydb.org that referenced this pull request Nov 27, 2017
dohrayme pushed a commit to dohrayme/flyway that referenced this pull request Feb 3, 2020
…jdbc-url

Support TestContainers JDBC connection string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.