Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow extending classpath in gradle task config #1738

Merged
merged 3 commits into from Feb 16, 2018
Merged

Conversation

@simschla
Copy link
Contributor

@simschla simschla commented Aug 9, 2017

especially to allow for custom org.gradle.api.artifacts.Configuration to be used for separating flyway java migrations from other code.

simschla added 2 commits Aug 7, 2017
this adds a testcase to show, that flyway migration fails for java migrations
when they use classes coming from a custom gradle configuration
this adds a property 'classpathExtension' that allows a user to extend
the classpath flyway uses to run its tasks and especially its java migrations.
@simschla
Copy link
Contributor Author

@simschla simschla commented Aug 15, 2017

Failing travis build seems unrelated to my change: Fails are in flyway-core...

@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Nov 30, 2017

@simschla Please sign the CLA and fix conflicts so this can be merged. Thanks!

@simschla
Copy link
Contributor Author

@simschla simschla commented Dec 1, 2017

@axelfontaine I'm a bit confused - did you actually delete all integration-tests such as the above confliciting GradleLargeTest.java? Or am I just to stupid to find the place in the repo where those things have been moved to?

@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Feb 13, 2018

@simschla Could you make this mergeable again so it can be included in 5.1.0? Thanks!

@simschla
Copy link
Contributor Author

@simschla simschla commented Feb 13, 2018

@axelfontaine Would love to do that, but am still waiting for your answer to my question above... Are all integration-tests gone? How would I go ahead and test my code in the current setup?

@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Feb 13, 2018

@simschla Yes, tests have been removed. We'll test it for you after merging.

@CLAassistant
Copy link

@CLAassistant CLAassistant commented Feb 14, 2018

CLA assistant check
All committers have signed the CLA.

# Conflicts:
#	flyway-gradle-plugin-largetest/src/test/java/org/flywaydb/gradle/largetest/GradleLargeTest.java
#	flyway-gradle-plugin/src/main/java/org/flywaydb/gradle/FlywayExtension.java
#	flyway-gradle-plugin/src/main/java/org/flywaydb/gradle/task/AbstractFlywayTask.java
@simschla simschla force-pushed the simschla:master branch from 06d36c0 to 090048b Feb 14, 2018
@simschla
Copy link
Contributor Author

@simschla simschla commented Feb 14, 2018

ready to merge - but please test thoroughly, since I cannot do that on my end.

@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Feb 14, 2018

@simschla Thanks. I assume it has passed your manual tests.

Could you also provide a pull request with a usage example for https://github.com/flyway/flywaydb.org/blob/flyway-5.1.0/documentation/gradle/index.md (flyway-5.1.0 branch)? This should most likely be a new ### section following https://flywaydb.org/documentation/gradle/#build-script-multiple-databases

@simschla
Copy link
Contributor Author

@simschla simschla commented Feb 15, 2018

I've added the documentation-pr: flyway/flywaydb.org#96

@axelfontaine axelfontaine merged commit 77859ae into flyway:master Feb 16, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
axelfontaine added a commit that referenced this pull request Feb 16, 2018
axelfontaine added a commit to flyway/flywaydb.org that referenced this pull request Feb 16, 2018
@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Feb 16, 2018

Thanks for the pull requests! Merged! As you can see I ended reworking the code quite a bit to allow for a more generic declarative specification of configurations.

P.S.: I also added you to the hall of fame page (flyway-5.1.0 branch).

@simschla
Copy link
Contributor Author

@simschla simschla commented Feb 16, 2018

Thanks for merging. I like your extensions to my extension-pullrequest ;-)
All the best with the upcoming release 5.1.0!

dohrayme pushed a commit to dohrayme/flyway that referenced this pull request Feb 3, 2020
Allow extending classpath in gradle task config
dohrayme pushed a commit to dohrayme/flyway that referenced this pull request Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants