Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New option to allow for 'Ignored' migrations in 'validate' command: ignoreIgnoredMigrations #1866

Merged
merged 3 commits into from Feb 13, 2018

Conversation

@bkaminnski
Copy link
Contributor

@bkaminnski bkaminnski commented Dec 12, 2017

This is a pull request for issue #1865.

The main change was done in MigrationInfoImpl class, where the new configuration flag is actually checked. All other changes are done taking as an example "flyway.ignoreMissingMigrations" configuration flag. I added a new option: "flyway.ignoreIgnoredMigrations". All changes in code take place next to a "missing" boolean flag.

I tried to follow all the conventions already applied in code. Also description of the configuration option in flyway.conf was done so that it is as similar to the description of surrounding "ignore..." flags, as possible.

…ignoreIgnoredMigrations'
@CLAassistant
Copy link

@CLAassistant CLAassistant commented Dec 12, 2017

CLA assistant check
All committers have signed the CLA.

@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Dec 13, 2017

Thanks. This looks great! Could you also make the necessary changes to the Maven and Gradle plugins?

…le plugin and maven plugins
@bkaminnski
Copy link
Contributor Author

@bkaminnski bkaminnski commented Dec 13, 2017

Done. Sorry I missed that. I also added info message to command-line help and checked that it now shows up. I haven't run flyway as maven nor gradle plugin though. Could you please let me know whether you have a quick way to verify that? I can do this, but I need little more time to set up maven and gradle plugin in my environment to make sure that this new flag is properly picked up also here.

@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Dec 13, 2017

Looking good!

All that is left now is the docs. Could you submit a pull request against the flyway-5.1.0 branch of flyway/flywaydb.org ? Thanks!

…IGNORE_IGNORED_MIGRATIONS'
@bkaminnski
Copy link
Contributor Author

@bkaminnski bkaminnski commented Dec 13, 2017

Done. What I noticed during update of documentation:

  1. I missed handling of FLYWAY_IGNORE_IGNORED_MIGRATIONS in env variables in ConfigUtils. Fixed in another commit in pull request.
  2. I updated 3 undo.md files (commandline, gradle and maven) - this is however not covered by opensource version, and I am not sure how this relates to my change.
  3. I skipped release notes and javadoc.
@axelfontaine axelfontaine merged commit cc478ab into flyway:master Feb 13, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
axelfontaine added a commit to flyway/flywaydb.org that referenced this pull request Feb 13, 2018
@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Feb 13, 2018

Thank you very much for the great work! Merged. I have also taken the liberty to add you to the Hall of Fame page (flyway-5.1.0 branch).

dohrayme pushed a commit to dohrayme/flyway that referenced this pull request Feb 3, 2020
New option to allow for 'Ignored' migrations in 'validate' command: ignoreIgnoredMigrations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.