Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not delete types that extensions depend on when cleaning PostgreSql #1932

Merged
merged 1 commit into from Feb 18, 2018

Conversation

@yankee42
Copy link
Contributor

@yankee42 yankee42 commented Feb 17, 2018

I cannot use clean in one of my projects, because I am using the btree_gist extension. I alway get the following error:

ERROR: cannot drop type gbtreekey4 because extension btree_gist requires it

This PR prevents that these types are dropped. Basically this is an extension to commit 444f077 which did the same for routines and views.

@CLAassistant
Copy link

@CLAassistant CLAassistant commented Feb 17, 2018

CLA assistant check
All committers have signed the CLA.

@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Feb 17, 2018

Related to #100

@axelfontaine axelfontaine added this to the Flyway 5.1.0 milestone Feb 17, 2018
@yankee42 yankee42 force-pushed the yankee42:fix-cannot-drop-type-extension branch from cebad7c to 70f737d Feb 18, 2018
@yankee42 yankee42 force-pushed the yankee42:fix-cannot-drop-type-extension branch from 70f737d to f16725b Feb 18, 2018
@axelfontaine axelfontaine merged commit 28f4474 into flyway:master Feb 18, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
axelfontaine added a commit that referenced this pull request Feb 18, 2018
axelfontaine added a commit to flyway/flywaydb.org that referenced this pull request Feb 18, 2018
@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Feb 18, 2018

Thanks for the pull request! Merged. I have also taken the liberty to add you to the Hall of Fame page (flyway-5.1.0 branch).

@yankee42 yankee42 deleted the yankee42:fix-cannot-drop-type-extension branch Feb 18, 2018
dohrayme pushed a commit to dohrayme/flyway that referenced this pull request Feb 3, 2020
…ension

Do not delete types that extensions depend on when cleaning PostgreSql
dohrayme pushed a commit to dohrayme/flyway that referenced this pull request Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants