NumberFormatException with file names like V1..1__desc.sql #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Thomas, thanks for your contribution! While I agreed with you that a NumberFormatException is not desirable here, I don't believe 1..1 should be allowed as a version. Could you rework the code so a FlywayException with a meaningful error message is thrown instead? Cheers |
|
Hi Axel, I fixed the parsing now. In the process of looking at the code again I also fixed the hashCode method. Thomas |
|
I like this change, it simplifies implementation 👍 |
axelfontaine
pushed a commit
that referenced
this pull request
Aug 20, 2013
NumberFormatException with file names like V1..1__desc.sql
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #572
As part of the fix I also fixed the compareTo implementation for MigrationVersion.EMPTY and MigrationVersion.LATEST and simplified the code a bit.