Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed parsing issue for MySQL where strings ending in a [space]x|b' #600

Merged
merged 1 commit into from Sep 12, 2013

Conversation

@bigslack
Copy link

@bigslack bigslack commented Sep 10, 2013

Fixed parsing issue for MySQL where strings ending in a [space]x|b' were not being terminated properly by the MySQLSqlStatementBuilder (see issue #593). Checked to see if token's length was greater than 2. Any bit or hex literal should at the minimum have a length of three (i.e. b'' or x'') but the case where a string ends with a [space]x|b' (i.e. ' x') then the length is only two. This seemed like the easiest way to determine if the token was truly a bit/hex literal or the ending sequence of a string. I also added two tests to test for the [space]x|b' case being improperly terminated.

…ere not being terminated properly by the MySQLSqlStatementBuilder
axelfontaine added a commit that referenced this pull request Sep 12, 2013
Fixed parsing issue  for MySQL where strings ending in a [space]x|b'
@axelfontaine axelfontaine merged commit 02b111d into flyway:master Sep 12, 2013
1 check passed
1 check passed
default The Travis CI build passed
Details
@bigslack bigslack deleted the bigslack:issue-593-fix branch Sep 12, 2013
@bigslack bigslack mentioned this pull request Dec 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.