Fixed parsing issue for MySQL where strings ending in a [space]x|b' #600
+18
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ere not being terminated properly by the MySQLSqlStatementBuilder
axelfontaine
pushed a commit
that referenced
this pull request
Sep 12, 2013
Fixed parsing issue for MySQL where strings ending in a [space]x|b'
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed parsing issue for MySQL where strings ending in a [space]x|b' were not being terminated properly by the MySQLSqlStatementBuilder (see issue #593). Checked to see if token's length was greater than 2. Any bit or hex literal should at the minimum have a length of three (i.e. b'' or x'') but the case where a string ends with a [space]x|b' (i.e. ' x') then the length is only two. This seemed like the easiest way to determine if the token was truly a bit/hex literal or the ending sequence of a string. I also added two tests to test for the [space]x|b' case being improperly terminated.