Issue 598 fix #609
Merged
Issue 598 fix #609
Conversation
added 2 commits
Sep 20, 2013
…ck to originalSchema. Should now properly handle setups where the datasource url does not have a schema defined but instead .setSchema() was used.
|
Hi Adam, thanks for the pull request. I merged it, added a test, found out it broke PostgreSQL support and eventually rewrote it :-) This should be easier to check in the future though, now that the Travis CI also runs the MySQL and PostgreSQL tests. Cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Patch to resolve most of issue #598. In particular cases 2 & 3 where the schema is set by .setSchema() and no schema is present in the datasource url.