Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #456. #616

Merged
merged 1 commit into from Oct 8, 2013
Merged

Fix for issue #456. #616

merged 1 commit into from Oct 8, 2013

Conversation

@bigslack
Copy link

@bigslack bigslack commented Sep 25, 2013

Fix for issue #456. Flyway is unable to correctly find the quote delimiter when there is an inline charset cast on the string literal. I added a new method to the SqlStatementBuilder.java that can be overridden in the dialect specific subclasses if other dialects need similar behavior. For the MySQLStatementBuilder.java, I added a list of the supported charsets and check to make sure the tokens do not contain a charset cast prefix. If so, then I remove the cast reference so the token can be evaluated properly for quotes.

…miter when there is an inline charset cast on the string literal.
axelfontaine added a commit that referenced this pull request Oct 8, 2013
@axelfontaine axelfontaine merged commit a51b1af into flyway:master Oct 8, 2013
1 check passed
1 check passed
default The Travis CI build passed
Details
@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Oct 8, 2013

Thank you very much Adam! Sorry for the delay on this pull request and the others. It's been a very busy few weeks for me. Merged.

@bigslack bigslack deleted the bigslack:issue-456-fix branch Oct 8, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants