Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improves sbt-plugin (less Option types, command line override, large-test) #662

Merged
merged 7 commits into from Dec 16, 2013

Conversation

@cdedie
Copy link
Contributor

@cdedie cdedie commented Dec 13, 2013

Changes

  • use Flyway defaults and no Option types as TaskSettings where possible
  • add command line override (per system properties)
  • add sbt plugin large test
@axelfontaine

This comment has been minimized.

Copy link

@axelfontaine axelfontaine commented on 4275755 Dec 12, 2013

From reading the code, I am unsure about the property override order.

Please make sure

system property > plugin config in sbt file > flyway default

Christian Dedie
@cdedie
Copy link
Contributor Author

@cdedie cdedie commented Dec 13, 2013

The property override is in right order (see large -test)

@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Dec 13, 2013

Great!

axelfontaine added a commit that referenced this pull request Dec 16, 2013
improves sbt-plugin (less Option types, command line override, large-test)
@axelfontaine axelfontaine merged commit 231728a into flyway:master Dec 16, 2013
1 check passed
1 check passed
default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.