Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added check to remove versoning on DB2 tables during clean. #664

Merged
merged 3 commits into from Dec 16, 2013

Conversation

@boothen
Copy link
Contributor

@boothen boothen commented Dec 13, 2013

Versioning tables are automatically deleted when the table they version are deleted during a clean.

Dropping versioning before the dropping of the tables allows the tables to be dropped without issue.

@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Dec 13, 2013

Thanks! Could you also add a small test case to make sure it doesn't break in the future?

@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Dec 13, 2013

Sorry, I just saw your commit and I think I didn't word my question well. What I meant was a testcase in DB2MigrationMediumTest that demonstrates the functionality against a real db2 instance.

Sorry for the confusion,
Axel

@boothen
Copy link
Contributor Author

@boothen boothen commented Dec 16, 2013

Hi Axel,

Sorry for the confusion. I've added in a test to cover the functionality. Let me know if I've missed anything.

Cheers,
Matt.

@axelfontaine axelfontaine merged commit b57c7fa into flyway:master Dec 16, 2013
1 check failed
1 check failed
default The Travis CI build could not complete due to an error
Details
@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Dec 16, 2013

Thanks Matt! Merged.

What's your last name (so I can add you to the Hall Of Fame credits)?

@boothen
Copy link
Contributor Author

@boothen boothen commented Dec 17, 2013

My name is Matt Garner.

Thanks for the inclusion. Cheers.

@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Aug 17, 2017

@boothen Could you get in touch with me via email? (axel at boxfuse.com) Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.