Added check to remove versoning on DB2 tables during clean. #664
Conversation
|
Thanks! Could you also add a small test case to make sure it doesn't break in the future? |
|
Sorry, I just saw your commit and I think I didn't word my question well. What I meant was a testcase in DB2MigrationMediumTest that demonstrates the functionality against a real db2 instance. Sorry for the confusion, |
|
Hi Axel, Sorry for the confusion. I've added in a test to cover the functionality. Let me know if I've missed anything. Cheers, |
|
Thanks Matt! Merged. What's your last name (so I can add you to the Hall Of Fame credits)? |
|
My name is Matt Garner. Thanks for the inclusion. Cheers. |
|
@boothen Could you get in touch with me via email? (axel at boxfuse.com) Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Versioning tables are automatically deleted when the table they version are deleted during a clean.
Dropping versioning before the dropping of the tables allows the tables to be dropped without issue.