Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enchancing stripDelimiter function to work properly with special unicode characters like umlauts etc. #674

Merged
merged 2 commits into from Feb 11, 2014

Conversation

@abinet
Copy link

@abinet abinet commented Jan 9, 2014

This is a fix for #673

@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Jan 12, 2014

Thanks for the pull request! I added some additional test cases. The reason the toLowercase() call is there is to support SqlServer's GO delimiter which can vary in case.

However, I have never been happy with the current solution, so any improvement in that area is welcome. Could you make sure your changes work with the new test cases?

Thanks
Axel

@abinet
Copy link
Author

@abinet abinet commented Jan 13, 2014

Hi Axel, where i can find this new test cases? I don't see any changes in master.

@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Jan 15, 2014

Hi Andriy,

Sorry you were right. Laptop, train and poor network are not a great combination :-)

They should be checked in now.

Maybe a simple solution could be to threat SqlServer separately, as it is the only DB where the delimiter is expected to be on its own line and it is case insensitive.

Cheers
Axel

@abinet
Copy link
Author

@abinet abinet commented Jan 15, 2014

Hi Axel,

As soon as non standard delimiter can be currently provided only in same MySQL file with sql statements, i assume that doing all this de-/capitalizing stuff for delimiter is an overhead.

If you've provided "GO" as delimiter at start, you shouldn't user "go" a line below.

Regards
Andriy

…code characters like umlauts etc.
axelfontaine added a commit that referenced this pull request Feb 11, 2014
enchancing stripDelimiter function to work properly with special unicode characters like umlauts etc.
@axelfontaine axelfontaine merged commit 3bb71da into flyway:master Feb 11, 2014
1 check passed
1 check passed
default The Travis CI build passed
Details
@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Feb 11, 2014

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.