Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 682 #683

Merged
merged 1 commit into from Feb 11, 2014
Merged

fix issue 682 #683

merged 1 commit into from Feb 11, 2014

Conversation

@regis-leray
Copy link

@regis-leray regis-leray commented Jan 27, 2014

I discover a big issue in the maven plugin in flyway 2.3.1, you cannot set any boolean property with a java system property in command line (like -Dflyway.outOfOrder=true).

i did some debuging and the method getBooleanProperty got a very small bug.
Boolean.getBoolean(systemPropertyValue) should be Boolean.getBoolean(systemPropertyName)

PS: i try with flyway 2.1.1 and its working,
i had a unit test

… disable parallel execution for maven surefire plugin
@regis-leray
Copy link
Author

@regis-leray regis-leray commented Feb 10, 2014

I had to disble the parallel mode of the surefire plugin, to be able to create a unit test using S
ystem.setProperty and System.clearProperty if not the test were failing

axelfontaine added a commit that referenced this pull request Feb 11, 2014
fix issue 682
@axelfontaine axelfontaine merged commit 9e8a7b2 into flyway:master Feb 11, 2014
1 check passed
1 check passed
default The Travis CI build passed
Details
@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Feb 11, 2014

Thanks!

@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Aug 17, 2017

@regis-leray Could you please get in touch with me via email? (axel at boxfuse.com) Thanks!

@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Aug 23, 2017

@regis-leray Did you get my previous message? Could you please get in touch with me via email? (axel at boxfuse.com) Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.