Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for #694 Allow specifying URL through system properties #700

Merged
merged 3 commits into from Feb 14, 2014

Conversation

@cdedie
Copy link
Contributor

@cdedie cdedie commented Feb 13, 2014

No description provided.

@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Feb 13, 2014

Please pull in the latest changes. The package name has changed from com.googlecode.flyway to org.flywaydb ...

@cdedie
Copy link
Contributor Author

@cdedie cdedie commented Feb 13, 2014

Done. Merged upstream master.

@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Feb 13, 2014

Could you also cover this in a large test? (Correct user but dummy or missing url in build file, with url overridden by System property passed from the command line)

@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Feb 13, 2014

Also please doublecheck if the answer here could not be improved: http://stackoverflow.com/questions/21634326/specifying-flywayurl-through-system-property-in-sbt

axelfontaine added a commit that referenced this issue Feb 14, 2014
fix for #694 Allow specifying URL through system properties
@axelfontaine axelfontaine merged commit 209fda0 into flyway:master Feb 14, 2014
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants