Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maven plugin: Expose new DB version in "flyway.current" property after migration #778

Merged
merged 1 commit into from Aug 3, 2014

Conversation

@michaelyaakoby
Copy link
Contributor

@michaelyaakoby michaelyaakoby commented Jun 17, 2014

Hi,

I'm using flyway in my code and maven and its awesome.
Recently I needed to be able to get, in maven, the current version after migration - my build is automatically invoking the migrate goal during install.

So I've extended the maven-plugin so after migration it records the current DB version in the "flyway.current" property.

In order to test this, I've also extended the maven-plugin-largetest to test the "executions" section of the plugin.

Right now I'm using a local version that includes this patch - will be great if you can merge it into flyway.

Thanks,
M.

BTW, this is my first pull request... so please educate me if I'm doing it wrong :-)

…B version in the "flyway.current" property.

This can later be used in maven builds that needs to know this version.

Also extended maven-plugin-largetest to test the "executions" section of the plugin.
axelfontaine added a commit that referenced this pull request Aug 3, 2014
Extended the maven-plugin so after migration it records the current DB version in the "flyway.current" property
@axelfontaine axelfontaine merged commit d3462d3 into flyway:master Aug 3, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Aug 3, 2014

Hi Michael,

sorry for the late reply. Nice, simple, and useful addition. Merged.

I've added you to the hall of fame (flyway-3.1 branch).

Thanks and keep the pull requests coming! Preferably file an issue first, so we can discuss potential details first.

Cheers
Axel

@axelfontaine axelfontaine changed the title Extended the maven-plugin so after migration it records the current DB version in the "flyway.current" property Maven plugin: Expose new DB version in "flyway.current" property after migration Aug 3, 2014
@michaelyaakoby
Copy link
Contributor Author

@michaelyaakoby michaelyaakoby commented Aug 3, 2014

Thanks, this was my first pull-request… so I wasn’t sure :D

Next time I’ll file an issue first.

Anyways, awesome design and product – in the past 10 years I’ve been implementing similar functionality again and again and again and wasn’t ever happy :D

Thanks,

Michael

From: Axel Fontaine [mailto:notifications@github.com]
Sent: Sunday, August 03, 2014 9:38 PM
To: flyway/flyway
Cc: michaelyaakoby
Subject: Re: [flyway] Extended the maven-plugin so after migration it records the current DB version in the "flyway.current" property (#778)

Hi Michael,

sorry for the late reply. Nice, simple, and useful addition. Merged.

I've added you to the hall of fame (flyway-3.1 branch).

Thanks and keep the pull requests coming! Preferably file an issue first, so we can discuss potential details first.

Cheers
Axel


Reply to this email directly or view it on GitHub #778 (comment) . https://github.com/notifications/beacon/5503849__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcyMjcxMDI4OSwiZGF0YSI6eyJpZCI6MzQ4MTgxMjJ9fQ==--a209a7906b003393a53e9e65a2089855a3bd8a47.gif

@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Aug 3, 2014

Thank you for the nice feedback. Truly appreciated :-)

@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Aug 17, 2017

@michaelyaakoby Could you get in touch with me via email? (axel at boxfuse.com) Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants