Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue n. 718 #780

Merged
merged 1 commit into from Aug 3, 2014
Merged

Fix for issue n. 718 #780

merged 1 commit into from Aug 3, 2014

Conversation

@cc-rock
Copy link
Contributor

@cc-rock cc-rock commented Jun 18, 2014

I've run all the tests (including commercial DBs) and they are all passing.
I've introduced a new test for SQLServer that reproduces the fixed issue (n.718) and that fails without my fix in the JdbcTemplate class.

cc-rock
@cc-rock
Copy link
Contributor Author

@cc-rock cc-rock commented Jun 18, 2014

On my dev VM all the tests are passing, so I can't figure out exactly why the automated build failed, but it seems more a temporary issue with mysql.. is there a way to retrigger the build?

@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Jun 18, 2014

Looks great! I'm currently in the process of drafting a CLA. I'll get back to you as soon as it's ready and then I'll merge the PR.

Cheers
Axel

axelfontaine added a commit that referenced this pull request Aug 3, 2014
Fix for issue n. 718
@axelfontaine axelfontaine merged commit 6dbd474 into flyway:master Aug 3, 2014
1 check failed
1 check failed
continuous-integration/travis-ci The Travis CI build failed
Details
@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Aug 3, 2014

Thanks Carlo! I decided to drop the idea of a CLA. Sorry for the wait. Merged.

I've added you to the hall of fame page.

Cheers
Axel

@cc-rock
Copy link
Contributor Author

@cc-rock cc-rock commented Aug 15, 2014

Cool, thanks to you @axelfontaine ! :-)

@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Aug 17, 2017

@cc-rock Could you please get in touch with me via email? (axel at boxfuse.com) Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.