Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sybase ASE support #880

Merged
merged 12 commits into from Oct 27, 2015
Merged

Sybase ASE support #880

merged 12 commits into from Oct 27, 2015

Conversation

@super132
Copy link
Contributor

@super132 super132 commented Nov 14, 2014

This is to address issue #102 feature request which to support Sybase. I can now only work and test on Sybase ASE and thus the changes here is to support Sybase ASE only.

Comments are highly welcomed.

Jason Wong added 3 commits Nov 4, 2014
Conflicts:
	flyway-core/src/test/java/org/flywaydb/core/DbCategory.java
@super132 super132 changed the title Issue 102 feature commit Issue #102 feature commit Nov 14, 2014
@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Jan 10, 2015

Hi Jason,

thanks for the PR. Please update to be mergeable. Also please provide a PR against flywaydb.org for the docs.

Cheers
Axel

Conflicts:
	flyway-core/src/main/java/org/flywaydb/core/internal/dbsupport/DbSupportFactory.java
@super132
Copy link
Contributor Author

@super132 super132 commented Jan 12, 2015

Hi Axel,

I have updated the codes with the latest codes in master branch, please have a check. I'll create another pull request to update the doc.

Thanks.

Sincerely,
Jason

@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Jan 12, 2015

One thing is bothering me: why did you duplicate all test cases?

@axelfontaine axelfontaine changed the title Issue #102 feature commit Sybase ASE support Jan 12, 2015
Jason Wong
@super132
Copy link
Contributor Author

@super132 super132 commented Jan 13, 2015

That is because the script that used in the parent test cases cannot be used in Sybase ASE as it needs to use "GO" to be the delimiter but not semicolon. Also, it does not support schema and thus I duplicated a set of test cases SQLs out. The only "duplicated" test cases from MigrationTestCase class is "failedMigration()" which has different line count when running Sybase ASE test SQLs and thus the validation needs to be changed. Other than that, all base test cases are reused.

@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Jan 13, 2015

GO: Can't you use the same strategy as was used for MS SQL Server?

Schema: What do you mean by "it does not support schema"? The reference docs seem to contradict this: http://infocenter.sybase.com/help/index.jsp?topic=/com.sybase.infocenter.dc36272.1550/html/commands/X48762.htm

@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Jan 13, 2015

Schema: hmm you are right, upon closer inspection their concept of a schema doesn't seem to match the way the rest of the industry sees this very much...

@axelfontaine axelfontaine added this to the Flyway 3.2 milestone Jan 13, 2015
@super132
Copy link
Contributor Author

@super132 super132 commented Jan 13, 2015

Yes, I have checked some sources and then concluded that Sybase schema is not something like what we have in Oracle or MS SQL. The schema_name.db_name notation is not supported in Sybase ASE 12.5 (The only Sybase that I have access to). Therefore, is there any better way to reuse the testing SQL scripts but can drop out the schema notation?

Sybase experts are welcomed to see if my understanding is correct.

@super132
Copy link
Contributor Author

@super132 super132 commented Jan 13, 2015

Axel, I will try refer to SQLite test cases as it does not support schema as well. Will update the PR.

@super132
Copy link
Contributor Author

@super132 super132 commented Jan 13, 2015

After checking with the test scripts. The test scripts delimited wtih semicolon cannot be accepted by Sybase ASE server. It seems like SQL server support semicolon as delimiter as well but not Sybase. I cannot find any delimiter conversion code in the test classes. Would you point me to the class or file if I missed something?

If duplicated SQL scripts are not preferred then I may look into writing conversion script to convert delimiter for testing.

@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Jan 13, 2015

OK, then it probably makes indeed more sense to duplicate them.

@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Mar 5, 2015

The plan now is to include this in 4.0 due in April. Can you make it mergeable again after 3.2 is out?

Thanks
Axel

@axelfontaine axelfontaine modified the milestones: Flyway 4.0, Flyway 3.2 Mar 5, 2015
@super132
Copy link
Contributor Author

@super132 super132 commented Mar 10, 2015

Hi Axel,

No problem. Please let me know when it is ready.

Thanks.
Jason

@mcai4gl2
Copy link

@mcai4gl2 mcai4gl2 commented Jun 8, 2015

Hi Axel,

We are currently evaluating flyway internally and would like to roll it out for most of our teams. One feature gap raised by one of our team is Sybase support. Looking at this thread, can you please provide some information regarding the timeline for 4.0 release?

Thanks a lot.

Geng

@caledhwa
Copy link

@caledhwa caledhwa commented Jun 29, 2015

Yes, also interested in this feature. Right now it's not mergeable. Can we get it mergeable and then added to master?

Conflicts:
	flyway-core/src/test/java/org/flywaydb/core/internal/dbsupport/mysql/MySQLMigrationMediumTest.java
@super132
Copy link
Contributor Author

@super132 super132 commented Jul 9, 2015

@axelfontaine I have merged the codes with the latest revision in master. Please take a look. Thanks.

@PratikModi
Copy link

@PratikModi PratikModi commented Aug 17, 2015

Any Update on when Flyway 4.0 will be released? Looking for forward to use Flyway with Sybase support. Please provide an update.

@PratikModi
Copy link

@PratikModi PratikModi commented Aug 18, 2015

Any date for Flyway 4.0 Release ?

@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Oct 2, 2015

Hi Jason,

Could you also add a pull request against the flyway-4.0 branch of flyway/flywaydb.org with a DB-specific page (like http://flywaydb.org/documentation/database/oracle.html) as well as details on how to set it up (http://flywaydb.org/contribute/code/database.html)?

I have been fighting last night to get Sybase (or SAP as it's now called) ASE 16 up and running without success on my Win 10 x64 machine.

Once those are through we should be OK for a speedy merge.

Cheers
Axel

@super132
Copy link
Contributor Author

@super132 super132 commented Oct 21, 2015

Hi @axelfontaine ,

I will try to make the PR this week. Sorry for the late response.

Thanks.

Jason

@super132
Copy link
Contributor Author

@super132 super132 commented Oct 27, 2015

Hi Axel,

I have submitted the PR against flyway-4.0 branch in flywaydb.org repository. Please take a look.

Thanks.

axelfontaine added a commit that referenced this pull request Oct 27, 2015
@axelfontaine axelfontaine merged commit e91e4d6 into flyway:master Oct 27, 2015
@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Oct 27, 2015

Thanks! Merged.

@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Aug 17, 2017

@super132 Could you please contact me by email at axel at boxfuse dot com ? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.