Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/soliddb support #886

Merged
merged 13 commits into from Jan 10, 2015
Merged

Conversation

@MichaelF25
Copy link
Contributor

@MichaelF25 MichaelF25 commented Nov 21, 2014

Fix #885 by providing support for the SolidDB database engine

@MichaelF25
Copy link
Contributor Author

@MichaelF25 MichaelF25 commented Nov 24, 2014

The verification phase fails on Travis CI - however, after installing all supported OSS DBs on my machine and executing mvn verify -P-CommercialDBTest, all tests were green.

@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Nov 24, 2014

Don't worry about this particular failure. That is unrelated and has been fixed.

@MichaelF25
Copy link
Contributor Author

@MichaelF25 MichaelF25 commented Dec 22, 2014

@axelfontaine From my point of view this feature is now complete. I've also added some documentation to flywaydb.org website. Anything else missing from your point of view?

@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Dec 23, 2014

Would you be willing to

  • support users if issues arise?
  • maintain this for future Flyway releases?
@MichaelF25
Copy link
Contributor Author

@MichaelF25 MichaelF25 commented Dec 23, 2014

@axelfontaine Sure, I'll take care of that

@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Dec 24, 2014

Then things are looking good for a merge in 3.2 :-)

axelfontaine added a commit that referenced this pull request Jan 10, 2015
Feature/soliddb support
@axelfontaine axelfontaine merged commit 64d2889 into flyway:master Jan 10, 2015
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Jan 10, 2015

Thanks! Merged! :-)

@MichaelF25 MichaelF25 deleted the MichaelF25:feature/soliddb-support branch Mar 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.