#895: Add qualified Gradle plugin ID, deprecate unqualified Gradle plugin ID #946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelfontaine
pushed a commit
that referenced
this pull request
Feb 25, 2015
#895: Add qualified Gradle plugin ID, deprecate unqualified Gradle plugin ID
|
Thanks. Excellent work! Merged. I've also added you to the hall of fame page (flyway-3.2 branch until merged). Cheers |
|
@davidmc24 Could you please get in touch with me via email (axel at boxfuse.com)? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is backwards-compatible. The existing "flyway" unqualified plugin ID is fully functional, albeit now with a logged warning message that it is deprecated. The new "org.flywaydb.flyway" qualified plugin ID has all the same capabilities, minus the warning.
To verify that this is actually the case, all the test coverage is duplicated, covering both the qualified and unqualified plugin IDs. In the case of
GradleLargeTest, theunqualifiedtest checks that there is a deprecation message in the output.In the next major version, it should be possible to remove
UnqualifiedFlywayPlugin.java,flyway.properties, and the associated test coverage.