Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#895: Add qualified Gradle plugin ID, deprecate unqualified Gradle plugin ID #946

Merged
merged 1 commit into from Feb 25, 2015

Conversation

@davidmc24
Copy link
Contributor

@davidmc24 davidmc24 commented Feb 4, 2015

This change is backwards-compatible. The existing "flyway" unqualified plugin ID is fully functional, albeit now with a logged warning message that it is deprecated. The new "org.flywaydb.flyway" qualified plugin ID has all the same capabilities, minus the warning.

To verify that this is actually the case, all the test coverage is duplicated, covering both the qualified and unqualified plugin IDs. In the case of GradleLargeTest, the unqualified test checks that there is a deprecation message in the output.

In the next major version, it should be possible to remove UnqualifiedFlywayPlugin.java, flyway.properties, and the associated test coverage.

axelfontaine added a commit that referenced this pull request Feb 25, 2015
#895: Add qualified Gradle plugin ID, deprecate unqualified Gradle plugin ID
@axelfontaine axelfontaine merged commit 4c5d34f into flyway:master Feb 25, 2015
@axelfontaine axelfontaine added this to the Flyway 3.2 milestone Feb 25, 2015
@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Feb 25, 2015

Thanks. Excellent work! Merged. I've also added you to the hall of fame page (flyway-3.2 branch until merged).

Cheers
Axel

@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Aug 17, 2017

@davidmc24 Could you please get in touch with me via email (axel at boxfuse.com)? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.