Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SQL syntax error in MetaDataTableImpl.java #969

Merged
merged 1 commit into from Mar 20, 2015

Conversation

@avesse
Copy link
Contributor

@avesse avesse commented Mar 11, 2015

Syntax error encountered on MySQL due to missing space after "OR" in SQL query in MetaDataTableImpl.java.

Syntax error encountered on MySQL due to missing space after "OR" in SQL query.
@avesse avesse changed the title Update MetaDataTableImpl.java Fix SQL syntax error in MetaDataTableImpl.java Mar 11, 2015
@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Mar 11, 2015

Thanks for the pull request. What version of MySQL is exhibiting this behavior? (Our MySQL tests don't seem affected, so I'm wondering)

@avesse
Copy link
Contributor Author

@avesse avesse commented Mar 11, 2015

It's actually not MySQL, but Clustrix, which uses MySQL's syntax.

axelfontaine added a commit that referenced this pull request Mar 20, 2015
Fix SQL syntax error in MetaDataTableImpl.java
@axelfontaine axelfontaine merged commit 450bb43 into flyway:master Mar 20, 2015
@axelfontaine
Copy link
Contributor

@axelfontaine axelfontaine commented Mar 20, 2015

Thanks! Merged. I've also listed you on the hall of fame page. Can you tell me a bit more about your experiences with using Flyway and Clustrix together? (you are the first one I'm aware of, so this is just personal curiosity)

@axelfontaine axelfontaine added this to the Flyway 3.2.1 milestone Mar 20, 2015
@avesse
Copy link
Contributor Author

@avesse avesse commented Mar 24, 2015

Cool :)

So far it's been good; we've only just started using it on Clustrix, but to date we've set up a new db using flyway, ran a migration on it, as well as a baseline plus migration on an existing db. This issue is the only one we've encountered.

All our other tooling also only supports MySQL explicitly, not Clustrix, but for the most part it all just works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants