Skip to content

fix(ci): tag master as latest and non-default branches as development…#9

Merged
ma-04 merged 2 commits into
masterfrom
fix/fix_ci_push
May 18, 2026
Merged

fix(ci): tag master as latest and non-default branches as development…#9
ma-04 merged 2 commits into
masterfrom
fix/fix_ci_push

Conversation

@ma-04
Copy link
Copy Markdown
Member

@ma-04 ma-04 commented May 18, 2026

Master pushes and manual runs were producing the development tag because
it was gated on is_default_branch. Flip the logic so master gets latest
and development is reserved for manual builds from other branches.

Summary by CodeRabbit

  • Chores
    • Improved Docker image tagging strategy: default branch releases now consistently tagged as latest, while development-branch builds receive distinct identification for clearer version management.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 18, 2026

Warning

Rate limit exceeded

@ma-04 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 46 minutes and 42 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f0ce7059-b55e-4974-b5fc-644a8dcd9dae

📥 Commits

Reviewing files that changed from the base of the PR and between c88820c and 2004e76.

📒 Files selected for processing (1)
  • .github/workflows/docker.yml

Walkthrough

The pull request updates Docker image tagging configuration in the CI workflow. It adds an explicit latest tag for the default branch and refines the development tag condition to target non-default branches while excluding release events and default-branch-triggered workflows.

Changes

Docker Image Tagging Strategy

Layer / File(s) Summary
Docker metadata tag definitions
.github/workflows/docker.yml
Docker metadata action configuration adds explicit latest tag enabled only on the default branch and updates development tag condition to exclude release events and default-branch-triggered workflows.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A tag for the latest, bright and clear,
Development builds when branches appear,
No releases mixed in the dev lane so fine,
Just feature and fix branches—all in line!
The workflow now knows which tag should shine.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: updating Docker tag generation to use 'latest' for master and 'development' for non-default branches.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/fix_ci_push

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/docker.yml:
- Line 40: Update the conditional that sets the development tag (the expression
in the type=raw,value=development,enable=... attribute) to ensure it only
applies to branch refs by adding a check for github.ref_type == 'branch'
alongside the existing checks on github.ref_name and github.event_name; modify
the enable expression so it requires github.ref_type == 'branch' AND
github.ref_name != github.event.repository.default_branch AND github.event_name
!= 'release' to prevent workflow_dispatch on tag refs from producing the
development tag.
🪄 Autofix (Beta)

❌ Autofix failed (check again to retry)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 74299c61-743a-4ba3-b8f7-e7da6dc67f45

📥 Commits

Reviewing files that changed from the base of the PR and between 53dc8ff and c88820c.

📒 Files selected for processing (1)
  • .github/workflows/docker.yml

Comment thread .github/workflows/docker.yml Outdated
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 18, 2026

Note

Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it.

Autofix skipped. No unresolved CodeRabbit review comments with fix instructions found.

@ma-04 ma-04 merged commit cf59ed8 into master May 18, 2026
6 checks passed
@ma-04 ma-04 deleted the fix/fix_ci_push branch May 18, 2026 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant