fix(ci): tag master as latest and non-default branches as development…#9
Conversation
… for manual build
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe pull request updates Docker image tagging configuration in the CI workflow. It adds an explicit ChangesDocker Image Tagging Strategy
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/docker.yml:
- Line 40: Update the conditional that sets the development tag (the expression
in the type=raw,value=development,enable=... attribute) to ensure it only
applies to branch refs by adding a check for github.ref_type == 'branch'
alongside the existing checks on github.ref_name and github.event_name; modify
the enable expression so it requires github.ref_type == 'branch' AND
github.ref_name != github.event.repository.default_branch AND github.event_name
!= 'release' to prevent workflow_dispatch on tag refs from producing the
development tag.
🪄 Autofix (Beta)
❌ Autofix failed (check again to retry)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 74299c61-743a-4ba3-b8f7-e7da6dc67f45
📒 Files selected for processing (1)
.github/workflows/docker.yml
|
Note Autofix is a beta feature. Expect some limitations and changes as we gather feedback and continue to improve it. Autofix skipped. No unresolved CodeRabbit review comments with fix instructions found. |
Master pushes and manual runs were producing the
developmenttag becauseit was gated on
is_default_branch. Flip the logic so master getslatestand
developmentis reserved for manual builds from other branches.Summary by CodeRabbit
latest, while development-branch builds receive distinct identification for clearer version management.