Skip to content

Conversation

Calinou
Copy link

@Calinou Calinou commented Jan 19, 2018

I investigated a build issue with @dom96 and fixed it by changing internalError from a template to a proc.

This is untested in real world use cases, I don't know if it breaks things; please test first before merging.

I investigated a build issue with @dom96 and fixed it by changing
`internalError` from a template to a proc.
@flyx
Copy link
Owner

flyx commented Jan 20, 2018

This fix is wrong because changing internalError to a proc would make the instantiationInfo useless as it would always report the source line of the the proc instead of the actual line in the code where the error occurs.

Also, when creating a PR, please describe the problem you intend to fix. I currently have little time and would be grateful if I wouldn't need to dig through the IRC log to get an error description ;).

@flyx
Copy link
Owner

flyx commented May 29, 2018

obsolete with #56

@flyx flyx closed this May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants