Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Severe rename bug deletes folders #357

Closed
zelk opened this issue Apr 13, 2018 · 10 comments
Closed

Severe rename bug deletes folders #357

zelk opened this issue Apr 13, 2018 · 10 comments

Comments

@zelk
Copy link

zelk commented Apr 13, 2018

Create a folder called "a". Rename it to "A". Notice how the folder and all its contents is deleted from the disk without warning. Only tested on Mac.

I just wiped an entire folder with lot's of data in it. I wanted to rename a folder called "agreements" to "Agreements". Luckily, I will be able to reproduce the information but others might not be so lucky.

@mherrmann
Copy link
Contributor

Sheesh I'm sorry. I will look at this straight away.

@raguay
Copy link

raguay commented Apr 13, 2018 via email

@mherrmann
Copy link
Contributor

I also cannot reproduce this. I create a folder "a" with a file "file.txt" in it. I then used Shift+F6 to rename the folder to "A". The folder was renamed and the file then existed at "A/file.txt", as expected. Any further light you could shed on this would be highly appreciated @zelk.

@zelk
Copy link
Author

zelk commented Apr 13, 2018

I can try again tomorrow. I used F6, not Shift-F6.

@raguay
Copy link

raguay commented Apr 14, 2018

F6 should of moved the folder to the directory in the other panel. Check the directory the other panel was in and your files should be there.

@zelk
Copy link
Author

zelk commented Apr 15, 2018

Yes, I know what F6 is supposed to do but I tend to use it also to rename things in the same folder (as I was not aware of Shift+F6). So, please try to reproduce the bug by renaming a folder using F6 instead of Shift+F6 and see if you can reproduce it. On my computer, there's a 100 % repro rate.

@zelk
Copy link
Author

zelk commented Apr 15, 2018

So, to be clear, position the cursor on a folder called "a", hit F6, remove everything in the textbox and only write "A". Notice that fman deletes the folder.

@mherrmann
Copy link
Contributor

You are right. I'm so sorry for this. I just fixed it. Will go live with upcoming fman 1.0.

@zelk
Copy link
Author

zelk commented Apr 17, 2018

Great work! :)

@mherrmann
Copy link
Contributor

Fix released as part of fman 1.0.0 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants