Severe rename bug deletes folders

[zelk]

Create a folder called "a". Rename it to "A". Notice how the folder and all its contents is deleted from the disk without warning. Only tested on Mac.

I just wiped an entire folder with lot's of data in it. I wanted to rename a folder called "agreements" to "Agreements". Luckily, I will be able to reproduce the information but others might not be so lucky.

[mherrmann]

Sheesh I'm sorry. I will look at this straight away.

[raguay]

I've tried several variations and I can't reproduce it. Does it happen all the time? I'm on a mac as well with the latest OS and fman 0.9.9. Also, the information should of been placed into the Trash unless you have finder turned off and my Flexible trash installed. Then it will be deleted permanently. Richard

…

On Fri, Apr 13, 2018 at 1:08 PM, Michael Herrmann ***@***.***> wrote: Sheesh I'm sorry. I will look at this straight away. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#357 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACX0x_zE2tw6-4qSwB_cC-7-eYyrMmaHks5toEDFgaJpZM4TS5dT> .

[mherrmann]

I also cannot reproduce this. I create a folder "a" with a file "file.txt" in it. I then used Shift+F6 to rename the folder to "A". The folder was renamed and the file then existed at "A/file.txt", as expected. Any further light you could shed on this would be highly appreciated @zelk.

[zelk]

I can try again tomorrow. I used F6, not Shift-F6.

[raguay]

F6 should of moved the folder to the directory in the other panel. Check the directory the other panel was in and your files should be there.

[zelk]

Yes, I know what F6 is supposed to do but I tend to use it also to rename things in the same folder (as I was not aware of Shift+F6). So, please try to reproduce the bug by renaming a folder using F6 instead of Shift+F6 and see if you can reproduce it. On my computer, there's a 100 % repro rate.

[zelk]

So, to be clear, position the cursor on a folder called "a", hit F6, remove everything in the textbox and only write "A". Notice that fman deletes the folder.

[mherrmann]

You are right. I'm so sorry for this. I just fixed it. Will go live with upcoming fman 1.0.

[zelk]

Great work! :)

[mherrmann]

Fix released as part of fman 1.0.0 :)