New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When opening a file its filename is evaluated as command instead of as file #372

Closed
vovcacik opened this Issue Apr 23, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@vovcacik

vovcacik commented Apr 23, 2018

This one is tricky. Fman is using cmd's start to open files. This is wrong because start is supposed to be invoked on other executables:

START ["title"] [/D path] [/I] [/MIN] [/MAX] [/SEPARATE | /SHARED]
      [/LOW | /NORMAL | /HIGH | /REALTIME | /ABOVENORMAL | /BELOWNORMAL]
      [/NODE <NUMA node>] [/AFFINITY <hex affinity mask>] [/WAIT] [/B]
      [command/program] [parameters]

It works in some scenarios and doesn't in others. Alternative would be to use explorer "file.txt" command instead. Or some API call.

Scenario:

  • lets say I create empty file touch.exe powershell
  • double click in fman will open the PowerShell terminal
  • it is same as calling start "powershell" on cmd which will sken the %PATH% and %PATHEXT% and eventually executes C:\Windows\System32\WindowsPowerShell\v1.0\powershell.EXE

Expected behaviour is that explorer will ask me what program I want to open the file with (as it is missing extension).

fman#372 using cmd-start instead of explorer to invoke files.zip

@vovcacik

This comment has been minimized.

vovcacik commented Apr 23, 2018

This is related to #369 but both are different bugs. However both can be fixed by not calling start "filename.txt" internally.

@mherrmann

This comment has been minimized.

Contributor

mherrmann commented Jul 17, 2018

Fixed in fman 1.1.4.

@mherrmann mherrmann closed this Jul 17, 2018

@mherrmann mherrmann removed the in progress label Jul 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment