Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Open terminal in current directory" poses security breach #382

Closed
disco-fella opened this issue Apr 29, 2018 · 2 comments
Closed

"Open terminal in current directory" poses security breach #382

disco-fella opened this issue Apr 29, 2018 · 2 comments
Labels

Comments

@disco-fella
Copy link

@disco-fella disco-fella commented Apr 29, 2018

"Open terminal in current directory" command runs cmd.exe using relative path. This approach poses security breach: if current working directory a contains malicious cmd.exe file (hidden one likely), the command runs this malicious file instead of running Windows' cmd.exe in C:\System.

@mherrmann
Copy link
Contributor

@mherrmann mherrmann commented Apr 30, 2018

Great catch, thank you. I fixed this now. Will go live with release 1.0.4.

@mherrmann
Copy link
Contributor

@mherrmann mherrmann commented May 2, 2018

Fixed in fman 1.0.4.

@mherrmann mherrmann closed this May 2, 2018
@mherrmann mherrmann removed the in progress label May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants