New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Open terminal in current directory" poses security breach #382

Closed
krankenbyte opened this Issue Apr 29, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@krankenbyte

krankenbyte commented Apr 29, 2018

"Open terminal in current directory" command runs cmd.exe using relative path. This approach poses security breach: if current working directory a contains malicious cmd.exe file (hidden one likely), the command runs this malicious file instead of running Windows' cmd.exe in C:\System.

@mherrmann

This comment has been minimized.

Contributor

mherrmann commented Apr 30, 2018

Great catch, thank you. I fixed this now. Will go live with release 1.0.4.

@mherrmann

This comment has been minimized.

Contributor

mherrmann commented May 2, 2018

Fixed in fman 1.0.4.

@mherrmann mherrmann closed this May 2, 2018

@mherrmann mherrmann removed the in progress label May 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment