New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter files as you type #41

Closed
mherrmann opened this Issue Mar 21, 2017 · 11 comments

Comments

Projects
None yet
4 participants
@mherrmann
Contributor

mherrmann commented Mar 21, 2017

Say you have

  • apple/
  • banana.txt
  • bananajuice.txt

When you type p, only apple/ should remain in the list of files and p should be highlighted. When you then press ESC, all files should be visible again. When you then type banana, only banana.txt and bananajuice.txt should be visible. Pressing Enter opens the currently selected file. Pressing Backspace deletes the last character from the current filter (eg. banana -> banan). If no filtering is currently taking place (eg. because the user pressed ESC), then Backspace should go up in the directory hierarchy.

This feature is closely related to #40 .

@mherrmann

This comment has been minimized.

Contributor

mherrmann commented May 25, 2017

@kszcode kindly published a plugin that implements functionality very similar to this one: https://github.com/kszcode/FuzzySearchFilesInCurrentFolder

@fman-issues-bot fman-issues-bot bot added 9 votes and removed 8 votes labels Jun 19, 2017

@fman-issues-bot fman-issues-bot bot added 10 votes and removed 9 votes labels Jun 26, 2017

@fman-issues-bot fman-issues-bot bot added 11 votes and removed 10 votes labels Jul 3, 2017

@fman-issues-bot fman-issues-bot bot added 12 votes and removed 11 votes labels Sep 4, 2017

@fman-issues-bot fman-issues-bot bot added 13 votes and removed 12 votes labels Sep 11, 2017

@mherrmann

This comment has been minimized.

Contributor

mherrmann commented Nov 1, 2017

@rogenaro, you asked for a way (setting/hotkey) to toggle between exact and fuzzy matching (/regex). What exactly do you mean by "exact" and "fuzzy" matching?

@rogenaro

This comment has been minimized.

rogenaro commented Nov 1, 2017

@mherrmann by fuzzy, I meant that we could type nn to match both banana.txt and bananajuice.txt, skipping characters in the filename as long as they exist in the same order typed in our query.

I misused the term "exact", I actually meant subsequent.
In some cases, it would be useful to match only the filenames without skipping, so we would have to type nan to match the same files, while nn would not match them, but would match annotation.txt, for example.

In regex we would just type a regular expression and match the results ( /^banana*\.txt$/ to get all txt files starting with banana, for example )

Depending on the contents of the directory, switching between those modes can be useful and time-saving

@mherrmann

This comment has been minimized.

Contributor

mherrmann commented Nov 2, 2017

@rogenaro I see, thanks for the clarification :-)

@fman-issues-bot fman-issues-bot bot added 14 votes and removed 13 votes labels Nov 29, 2017

@mherrmann

This comment has been minimized.

Contributor

mherrmann commented Sep 12, 2018

Implemented in fman 1.3.1. 🎉

@mherrmann mherrmann closed this Sep 12, 2018

@mherrmann mherrmann removed the in progress label Sep 12, 2018

@oskretc

This comment has been minimized.

oskretc commented Sep 12, 2018

👏👏👏
This bring fman from a really nice experiment to super file browser. Kudos on adding this feature.

one thing, maybe add a visual distinctive to the panel to indicate that files are being filtered.

@mherrmann

This comment has been minimized.

Contributor

mherrmann commented Sep 12, 2018

Thanks! I'm happy to hear you like it. Regarding your suggestion, please file a new issue if you feel it's important. Makes it easier for me to keep track.

@mherrmann

This comment has been minimized.

Contributor

mherrmann commented Sep 13, 2018

I created the new issue for visual feedback that files are being filtered now: #511.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment