New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better progress feedback for file operations #46

Closed
mherrmann opened this Issue Mar 21, 2017 · 13 comments

Comments

Projects
None yet
4 participants
@mherrmann
Contributor

mherrmann commented Mar 21, 2017

Currently, fman prints what files it is currently operating on in the status bar. It would be nicer to have (say) a progress bar. But should be unobtrusive/non-blocking. A user pointed out that time estimates are probably impossible to get right, so best to avoid them entirely.

@mherrmann

This comment has been minimized.

Contributor

mherrmann commented Jun 7, 2017

Further requirements / nice to haves:

  • Any plugin should be able to display progress feedback via fman's API.
  • It would be nice if the user were also able to pause / abort the long running operations (if the plugin supports it).
  • The progress feedback should make it possible to display errors specific to that operation.
@mherrmann

This comment has been minimized.

Contributor

mherrmann commented Jun 7, 2017

@joshas suggested maybe taking Filezilla as an inspiration for what the progress feedback could look like.

@fman-issues-bot fman-issues-bot bot added 5 votes and removed 4 votes labels Jun 20, 2017

@fman-issues-bot fman-issues-bot bot added 6 votes and removed 5 votes labels Jul 3, 2017

@webdesus

This comment has been minimized.

webdesus commented Aug 21, 2017

Maybe better make core plugin? I think in a future fman have many plugins for copy use ftp protocol, smb, and etc. I think if we will be bet common interface for control copy operations, all future plugins created for file operations, can use this common UI. What do you think about it?

@mherrmann

This comment has been minimized.

Contributor

mherrmann commented Aug 22, 2017

@webdesus yes, that's the plan. There should be an API for displaying progress dialogs. Every plugin (including Core) can then use this API to show progress, handle cancellation etc.

@webdesus

This comment has been minimized.

webdesus commented Aug 22, 2017

I get your point. you use Atom plugin Ideology))) Next question. Do you will make opportunity or it's task for community folks?

@mherrmann

This comment has been minimized.

Contributor

mherrmann commented Aug 22, 2017

I will do it :)

@fman-issues-bot fman-issues-bot bot added 7 votes and removed 6 votes labels Aug 22, 2017

@fman-issues-bot fman-issues-bot bot added 8 votes and removed 7 votes labels Oct 21, 2017

@Greyvend

This comment has been minimized.

Greyvend commented Nov 3, 2017

Any updates on the progress feedback? I'd say it's the only minimally required file manager feature that fman currently lacks.

@fman-issues-bot fman-issues-bot bot added 9 votes and removed 8 votes labels Nov 3, 2017

@mherrmann

This comment has been minimized.

Contributor

mherrmann commented Nov 3, 2017

@Greyvend I'm currently working on a new file system backend that will make it possible to implement / fix #2, #30, #31, #32, #37 and many others. I agree with you that progress feedback is likely the most important "basic" feature that's still missing. I will implement it once I'm finished with the new file system backend.

@Greyvend

This comment has been minimized.

Greyvend commented Nov 3, 2017

@mherrmann any idea when it could be finished?

@mherrmann

This comment has been minimized.

Contributor

mherrmann commented Nov 3, 2017

@Greyvend can't say precisely. Maybe Jan/Feb?

@fman-issues-bot fman-issues-bot bot added 10 votes and removed 9 votes labels Nov 29, 2017

@mherrmann

This comment has been minimized.

Contributor

mherrmann commented Jul 11, 2018

Implemented in fman 1.1.2. Woohoo! 🎉

@mherrmann mherrmann closed this Jul 11, 2018

@mherrmann mherrmann removed the in progress label Jul 11, 2018

@joshas

This comment has been minimized.

joshas commented Jul 11, 2018

While file operations progress display is really needed addition, I was hoping for fman to implement it in more modern way, e.g. in the bottom part of window, to let user continue his work, while file operations are processing in the background. I agree, that in some cases that might make problems (working on files being deleted). How about adding "Move task to background" button, like in Total Commander?

@mherrmann

This comment has been minimized.

Contributor

mherrmann commented Jul 11, 2018

@joshas feel free to open a new issue :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment