Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search doesn't prioritize closest match #539

Closed
CoenraadS opened this issue Oct 6, 2018 · 5 comments
Closed

Search doesn't prioritize closest match #539

CoenraadS opened this issue Oct 6, 2018 · 5 comments

Comments

@CoenraadS
Copy link

CoenraadS commented Oct 6, 2018

image

image

I am typing 'proje' to get into my projects folder, which I would expect to be closest match

@IgorKrupenja
Copy link

This is due to matching being set to *str* instead of str* starting from 1.3.2. I think the best option solution would be to allow users to configure the desired behaviour in the settings file. @mherrmann, for some more ideas with usage examples, please also see my comment at #512 (comment).

@mherrmann
Copy link
Contributor

That's exactly the case I was worried about when implementing #512. If str* is the default, then you can always type in the leading * for a substring (rather than a prefix) match. But not the other way around.

I'm somewhat weary of configuration options, because most users will never realize they're there. The default behavior needs to be "good enough".

@krupenja can't you fix your "dropbox" example by not displaying hidden files? This should get rid of the .dropbox... folders, shouldn't it?

I'll think about this a little.

@rmgk
Copy link

rmgk commented Oct 23, 2018

In case you did not consider this: it seems possible to do both for this use case, filter by sub string, but move the cursor to the first prefix match.
At least for my use cases, it seems that prefix match is only preferable for element selection, not filtering.

@mherrmann
Copy link
Contributor

That's a very good idea @rmgk. I implemented it this way now. Will go live with fman 1.3.7.

@mherrmann
Copy link
Contributor

Implemented in fman 1.3.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants